Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48641 )
Change subject: mb/google/dedede: Update Boten setting for USI PEN detection.
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48641/1/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/boten/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/48641/1/src/mainboard/google/dedede...
PS1, Line 119:
Thanks for remind. Done.
This is still missing in latest patchset.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48641
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I74a17088da64c22ef1c74d201c80274fc65a44c9
Gerrit-Change-Number: 48641
Gerrit-PatchSet: 2
Gerrit-Owner: rasheed.hsueh
rasheed.hsueh@lcfc.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jerry2 Huang
jerry2.huang@lcfc.corp-partner.google.com
Gerrit-CC: Kevin Chang
kevin.chang@lcfc.corp-partner.google.com
Gerrit-CC: Stanley Wu
stanley1.wu@lcfc.corp-partner.google.com
Gerrit-CC: Sunshine Chao
sunshine.chao@lcfc.corp-partner.google.com
Gerrit-CC: Will Lee
wwlee@google.com
Gerrit-Comment-Date: Wed, 16 Dec 2020 01:19:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: rasheed.hsueh
rasheed.hsueh@lcfc.corp-partner.google.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment