[coreboot-gerrit] Change in coreboot[master]: mb/ocp/monolake: Configure IPMI BMC FRB2 watchdog timer via VPD varia...

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36180 )

Change subject: mb/ocp/monolake: Configure IPMI BMC FRB2 watchdog timer via VPD variables
......................................................................

Patch Set 3:

(2 comments)

https://review.coreboot.org/c/coreboot/+/36180/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/36180/3//COMMIT_MSG@14 
PS3, Line 14: error
How does that work? If you reset the training will fail again on the same place.

https://review.coreboot.org/c/coreboot/+/36180/3/src/mainboard/ocp/monolake/... 
File src/mainboard/ocp/monolake/mainboard.c:

https://review.coreboot.org/c/coreboot/+/36180/3/src/mainboard/ocp/monolake/... 
PS3, Line 62: 1
Use enum instead