Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43571 )
Change subject: mb/system76/lemp9/gpio: 2/2 Convert field macros to PAD_CFG
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43571/3/src/mainboard/system76/lemp...
File src/mainboard/system76/lemp9/gpio.h:
https://review.coreboot.org/c/coreboot/+/43571/3/src/mainboard/system76/lemp...
PS3, Line 143: PAD_CFG_GPI_APIC
same as above
btw. I'm not sure if that is right at all... this is the interrupt used for the touchpad, so probably this should be PAD_CFG_GPI_APIC_EDGE_LOW(GPP_B3, NONE, PLTRST) or even PAD_CFG_GPI_IRQ_WAKE(GPP_B3, NONE, PLTRST, LEVEL, INVERT)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43571
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0225cff1ecac8c2ba181239e924ff508add94ad6
Gerrit-Change-Number: 43571
Gerrit-PatchSet: 3
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 19 Jul 2020 14:40:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner
Gerrit-MessageType: comment