Attention is currently required from: Maciej Pijanowski, Michał Kopeć, Michał Żygowski, Tim Crawford.
Krystian Hebel has posted comments on this change by Michał Kopeć. ( https://review.coreboot.org/c/coreboot/+/82673?usp=email )
Change subject: mb/novacustom: add V5x0TU board (Meteor Lake)
......................................................................
Patch Set 15:
(1 comment)
File src/mainboard/novacustom/mtl-h/ramstage.c:
https://review.coreboot.org/c/coreboot/+/82673/comment/7a379693_4e5e5e4b?usp... :
PS12, Line 3: #include <ec/dasharo/ec/commands.h>
: #include <ec/acpi/ec.h>
: #include <ec/dasharo/ec/acpi.h>
: #include <fmap.h>
: #include <lib.h>
: #include <mainboard/gpio.h>
: #include <security/vboot/vboot_common.h>
Not all of those are needed. It seems that only functions from `mainboard/gpio.h` and `ec/acpi. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82673?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I82c73ddb1e76a9baf9b97e13124aa249ae1c2771
Gerrit-Change-Number: 82673
Gerrit-PatchSet: 15
Gerrit-Owner: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Tim Crawford
tcrawford@system76.com
Gerrit-Attention: Tim Crawford
tcrawford@system76.com
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Comment-Date: Wed, 18 Sep 2024 10:51:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Krystian Hebel
krystian.hebel@3mdeb.com