Attention is currently required from: Kapil Porwal, Nick Vaccaro, sridhar siricilla.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80362?usp=email )
Change subject: soc/intel/cmn/sa: Add APIs into System Agent (SA) common code ......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/common/block/systemagent/systemagent_def.h:
https://review.coreboot.org/c/coreboot/+/80362/comment/4c6a4601_7b72ff3f : PS3, Line 32: #define MASK_PCIEXBAR_LENGTH 0x0000000E /* bits 1-3 */ : #define PCIEXBAR_LENGTH_LSB 1 /* used to shift right */ : #define MASK_DSM_LENGTH 0xFF00 /* bits 8-15 */ : #define MASK_DSM_LENGTH_LSB 8 /* used to shift right */ : #define MASK_GSM_LENGTH 0xC0 /* bits 6-7 */ : #define MASK_GSM_LENGTH_LSB 6 /* used to shift right */ : #define MASK_DPR_LENGTH 0xFF0 /* bits 4-11 */ : #define MASK_DPR_LENGTH_LSB 4 /* used to shift right */
Alignment issue here too !
Acknowledged