Attention is currently required from: Eric Lai, Paul Menzel, Tarun Tuli.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75756?usp=email )
Change subject: arch/x86: Introduce DUMP_SMBIOS_TYPE17 config
......................................................................
Patch Set 5:
(2 comments)
File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/75756/comment/0dfb6ea2_06116e2b :
PS5, Line 263: if (code >= 0x01 && code <= 0x23)
: return type[code - 0x01];
: return "Unsupported memory type";
WDYT?
```
if (!(code >= 0x01 && code <= 0x23))
return "Unsupported memory type";
return type[code - 0x01];
```
https://review.coreboot.org/c/coreboot/+/75756/comment/2cad3203_38c81ebb :
PS5, Line 1046:
i would have called below func from here
```
if (CONFIG(DUMP_SMBIOS_TYPE17))
dump_smbios_type17(dimm);
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75756?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2b5ca1f4a59598531a6cba500672c2717f2a7b00
Gerrit-Change-Number: 75756
Gerrit-PatchSet: 5
Gerrit-Owner: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Mon, 12 Jun 2023 09:27:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment