Attention is currently required from: Nicholas Chin.
Iru Cai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79746?usp=email )
Change subject: mainboard: add Dell Latitude E7240
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
Perhaps it didn't reuse CB:40300 because it is abandonded. […]
I wrote the same "chip ec/dell/mec5035" block as e6400. I just noticed that the EC driver also uses 0x910/0x911 ports, but I don't enable these ports after bootblock. I'll try to enable these ports in ramstage and test again.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79746?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6933bdbcc8d0bbb85d62657624740266284ac71c
Gerrit-Change-Number: 79746
Gerrit-PatchSet: 2
Gerrit-Owner: Iru Cai
mytbk920423@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Attention: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Comment-Date: Wed, 27 Dec 2023 02:06:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nicholas Chin
nic.c3.14@gmail.com
Comment-In-Reply-To: Iru Cai
mytbk920423@gmail.com
Gerrit-MessageType: comment