HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43348 )
Change subject: nb/intel/sandybridge: Add missing includes
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43348/8/src/northbridge/intel/sandy...
File src/northbridge/intel/sandybridge/memmap.c:
https://review.coreboot.org/c/coreboot/+/43348/8/src/northbridge/intel/sandy...
PS8, Line 13: #include <stddef.h>
: #include <stdint.h>
Wouldn't it make more sense to include <types. […]
I would use types if more than 2 headers are needed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43348
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9d54d0923a595734a84256ddcafb9dae17615cb0
Gerrit-Change-Number: 43348
Gerrit-PatchSet: 8
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 22 Jul 2020 08:03:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment