Attention is currently required from: Bao Zheng, Jason Nien, Paul Menzel.
Al Hirani has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62911 )
Change subject: amdfwtool: Allow for the tool to support additional PSP entries.
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62911/comment/e81a6f65_9730264a
PS2, Line 8:
What PSP entries are not supported right now? Please start with a description of the problem.
The tool has a limit to the number of PSP entries it can take as an input, so I can't specify which PSP entries because that's up to the user of the tool.
https://review.coreboot.org/c/coreboot/+/62911/comment/45c42e91_1580444e
PS2, Line 9: Consolidate the MAX_BIOS_ENTRIES and MAX_PSP_ENTRIES definitions into one file
Please wrap lines after 72 characters, and add a dot/period to the end of sentences.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62911
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie3c64a1875010e7fb368967283df6baf1cc7ba8d
Gerrit-Change-Number: 62911
Gerrit-PatchSet: 3
Gerrit-Owner: Al Hirani
al.hirani13@gmail.com
Gerrit-Reviewer: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ritul guru
ritul.bits@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Fri, 15 Apr 2022 16:48:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment