Johanna Schander has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34537 )
Change subject: src/device/oprom: Fix bootsplash display code for optionroms ......................................................................
Patch Set 18:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34537/15/src/device/pci_device.c File src/device/pci_device.c:
https://review.coreboot.org/c/coreboot/+/34537/15/src/device/pci_device.c@77... PS15, Line 772: #if CONFIG(BOOTSPLASH)
And pci_device.c should be even more unaware of vesa headers than bootsplash.c.
i created a set_vesa_bootsplash wrapper around set_bootsplash
https://review.coreboot.org/c/coreboot/+/34537/17/src/lib/bootsplash.h File src/lib/bootsplash.h:
https://review.coreboot.org/c/coreboot/+/34537/17/src/lib/bootsplash.h@15 PS17, Line 15:
We generally always guard header files […]
Done
https://review.coreboot.org/c/coreboot/+/34537/17/src/lib/bootsplash.c File src/lib/bootsplash.c:
https://review.coreboot.org/c/coreboot/+/34537/17/src/lib/bootsplash.c@19 PS17, Line 19: #include "bootsplash.h"
IMHO <bootsplash.h> and the file added would be src/include/bootsplash. […]
For some reason there are a lot of headers in src/lib. I will move it