Sricharan Ramabadhran has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29949 )
Change subject: mainboard/google/mistral: Add support for Mistral ......................................................................
Patch Set 11:
(2 comments)
https://review.coreboot.org/#/c/29949/2/src/mainboard/google/mistral/memlayo... File src/mainboard/google/mistral/memlayout.ld:
https://review.coreboot.org/#/c/29949/2/src/mainboard/google/mistral/memlayo... PS2, Line 16:
There shouldn't be a space here (guess that's wrong in Cheza, too).
ok, will fix this
https://review.coreboot.org/#/c/29949/2/src/mainboard/google/mistral/romstag... File src/mainboard/google/mistral/romstage.c:
https://review.coreboot.org/#/c/29949/2/src/mainboard/google/mistral/romstag... PS2, Line 22: #include <arch/stages.h>
In general, do not define functions until you need them (e.g. […]
ok, will fix. Will move this to the patch that uses it first.