Nico Huber (nico.h@gmx.de) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16675
-gerrit
commit 8c433f2f6e08f590a9ce5729e8c5f8eafa44f059 Author: Nico Huber nico.huber@secunet.com Date: Tue Sep 20 12:59:53 2016 +0200
buildgcc: Warn when building GCC with a different major version
GCC build instruction recommend to bootstrap a native compiler first. Not sure, when that is really necessary. A major version change seems reasonable.
Change-Id: I80a9ec25739b7d33a1d1c7b4b2140d19d89a99ae Signed-off-by: Nico Huber nico.huber@secunet.com --- util/crossgcc/buildgcc | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index c66bfe6..8a0127e 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -225,6 +225,16 @@ hostcc_version() { printf "%d.%d" "$(hostcc_major)" "$(hostcc_minor)" }
+check_cc() { + if is_package_enabled "GCC"; then + if [ "$(hostcc_major)" != "$(buildcc_major)" -a "${BOOTSTRAP}" != "1" ]; then + printf "\n${red}warning: Building GCC $(buildcc_version) with a different major " + printf "version ($(hostcc_version)).\n" + printf " Bootstrapping (-b) is recommended.${NC}\n\n" + fi + fi +} + check_sum() { test -z "$CHECKSUM" || \ test "$(cat sum/$1.cksum 2>/dev/null | sed -e 's@.*([0-9a-f]{40,}).*@\1@')" = \ @@ -829,6 +839,9 @@ searchtool bzip2 "bzip2," > /dev/null
check_for_library "-lz" "zlib (zlib1g-dev or zlib-devel)"
+CC=cc +check_cc + if [ "$HALT_FOR_TOOLS" -ne 0 ]; then exit 1 fi @@ -841,7 +854,6 @@ fi
# Set up host compiler and flags needed for various OSes
-CC=cc if is_package_enabled "GCC"; then if [ $UNAME = "Darwin" ]; then #GCC_OPTIONS="$GCC_OPTIONS --enable-threads=posix"