Attention is currently required from: Tim Crawford, Nico Huber, Patrick Rudolph, Jeremy Soller, Tim Wawrzynczak, Christian Walter.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60203 )
Change subject: mainboard: Fix DPTF device state in the devicetree on CFL boards
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60203/comment/0149dab7_363dcf57
PS2, Line 14: Thus, set it to on to make the resource allocator aware of it.
Worth to mention in the commit message, IMHO. Or just rephrase. Currently […]
Just copied the statement from below. Changes to the devicetree always have further implications. I haven't listed each side effect in any of my other patches hooking up the FSP options to the devicetree. Not sure why this is necessary here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60203
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I561598c252c5da64ece569c6ba336852e713ccab
Gerrit-Change-Number: 60203
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Tim Crawford
tcrawford@system76.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tim Crawford
tcrawford@system76.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jeremy Soller
jeremy@system76.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Comment-Date: Thu, 23 Dec 2021 03:08:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment