24 Apr
2019
24 Apr
'19
10:18 a.m.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32376 )
Change subject: superio/fintek/f71808a: Add more optional ramstage registers ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/32376/4/src/superio/fintek/f71808a/f71808a_h... File src/superio/fintek/f71808a/f71808a_hwm.c:
https://review.coreboot.org/#/c/32376/4/src/superio/fintek/f71808a/f71808a_h... PS4, Line 96: reg->hwm_fan1_seg5_speed);
then it will be ignored (kept default).
but if you don't want to default, but write zero to it?
--
To view, visit https://review.coreboot.org/c/coreboot/+/32376
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5d8008176d2972976b387c558658b8e70b50af8e
Gerrit-Change-Number: 32376
Gerrit-PatchSet: 4
Gerrit-Owner: Max Blau
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Max Blau
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Wed, 24 Apr 2019 10:18:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Max Blau
Comment-In-Reply-To: Patrick Rudolph siro@das-labor.org
Gerrit-MessageType: comment