Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42839 )
Change subject: superio/nuvoton: Avoid NULL pointer dereference ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42839/3/src/superio/nuvoton/npcd378... File src/superio/nuvoton/npcd378/superio.c:
https://review.coreboot.org/c/coreboot/+/42839/3/src/superio/nuvoton/npcd378... PS3, Line 329: printk(BIOS_ERR, "Device scope does not exist.\n"); Error messages should be understandable by a “normal” user. Please add some kind of prefix, and add the effect, like that the ACPI table might be incomplete or so.