[coreboot-gerrit] Change in coreboot[master]: nb/intel/common: Introduce common MCHBAR accessor functions

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45517 )

Change subject: nb/intel/common: Introduce common MCHBAR accessor functions
......................................................................

Patch Set 13:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45517/13/src/northbridge/intel/comm... 
File src/northbridge/intel/common/mchbar_ops.h:

https://review.coreboot.org/c/coreboot/+/45517/13/src/northbridge/intel/comm... 
PS13, Line 88: __always_inline void mchbar8_set(unsigned int offset, u8 set)
> Slow down please. With macros instead of functions we'd lose the typing […]

Very true. In that case, I'd just add the `_mask` suffix.