build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25634 )
Change subject: soc/intel/common: Implement EFI_MP_SERVICES_PPI structure APIs ......................................................................
Patch Set 38:
(11 comments)
https://review.coreboot.org/#/c/25634/38/src/soc/intel/common/block/cpu/mp_s... File src/soc/intel/common/block/cpu/mp_service_ppi.c:
https://review.coreboot.org/#/c/25634/38/src/soc/intel/common/block/cpu/mp_s... PS38, Line 47: CONST EFI_PEI_SERVICES **ignored1, need consistent spacing around '*' (ctx:WxO)
https://review.coreboot.org/#/c/25634/38/src/soc/intel/common/block/cpu/mp_s... PS38, Line 64: CONST EFI_PEI_SERVICES **ignored1, need consistent spacing around '*' (ctx:WxO)
https://review.coreboot.org/#/c/25634/38/src/soc/intel/common/block/cpu/mp_s... PS38, Line 67: EFI_PROCESSOR_INFORMATION *ProcessorInfoBuffer need consistent spacing around '*' (ctx:WxV)
https://review.coreboot.org/#/c/25634/38/src/soc/intel/common/block/cpu/mp_s... PS38, Line 92: CONST EFI_PEI_SERVICES **ignored1, need consistent spacing around '*' (ctx:WxO)
https://review.coreboot.org/#/c/25634/38/src/soc/intel/common/block/cpu/mp_s... PS38, Line 97: VOID *ProcedureArgument need consistent spacing around '*' (ctx:WxV)
https://review.coreboot.org/#/c/25634/38/src/soc/intel/common/block/cpu/mp_s... PS38, Line 116: CONST EFI_PEI_SERVICES **ignored1, need consistent spacing around '*' (ctx:WxO)
https://review.coreboot.org/#/c/25634/38/src/soc/intel/common/block/cpu/mp_s... PS38, Line 121: VOID *ProcedureArgument need consistent spacing around '*' (ctx:WxV)
https://review.coreboot.org/#/c/25634/38/src/soc/intel/common/block/cpu/mp_s... PS38, Line 146: CONST EFI_PEI_SERVICES **ignored1, need consistent spacing around '*' (ctx:WxO)
https://review.coreboot.org/#/c/25634/38/src/soc/intel/common/block/cpu/mp_s... PS38, Line 157: CONST EFI_PEI_SERVICES **ignored1, need consistent spacing around '*' (ctx:WxO)
https://review.coreboot.org/#/c/25634/38/src/soc/intel/common/block/cpu/mp_s... PS38, Line 161: UINT32 *HealthFlag need consistent spacing around '*' (ctx:WxV)
https://review.coreboot.org/#/c/25634/38/src/soc/intel/common/block/cpu/mp_s... PS38, Line 168: CONST EFI_PEI_SERVICES **PeiServices, need consistent spacing around '*' (ctx:WxO)