Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44568 )
Change subject: mb/google/asurada: Init dram in romstage ......................................................................
Patch Set 6:
(4 comments)
https://review.coreboot.org/c/coreboot/+/44568/5/src/mainboard/google/asurad... File src/mainboard/google/asurada/romstage.c:
https://review.coreboot.org/c/coreboot/+/44568/5/src/mainboard/google/asurad... PS5, Line 21: #lx
"#zx" for size_t
Ack
https://review.coreboot.org/c/coreboot/+/44568/5/src/mainboard/google/asurad... PS5, Line 21: #lx
"#zx" for size_t
Ack
https://review.coreboot.org/c/coreboot/+/44568/5/src/mainboard/google/asurad... PS5, Line 30: printk(BIOS_DEBUG, "write data from flash, ret=%#lx, length=%#lx\n", ret, length);
Same. […]
Ack
https://review.coreboot.org/c/coreboot/+/44568/5/src/mainboard/google/asurad... PS5, Line 36: = {0x0}
I think there's no need to explicitly initialize this to 0.
Ack