Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36081 )
Change subject: vc/amd/agesa/f16kb: Cast to UINT64 to avoid overflow ......................................................................
Patch Set 5: Code-Review+2
(4 comments)
https://review.coreboot.org/c/coreboot/+/36081/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36081/1//COMMIT_MSG@7 PS1, Line 7: vendorcode/amd/agesa/f16kb/Proc/Mem/Feat/DMI: Overflow before widen
Please make this a statement by adding a verb in imperative mood. […]
Done
https://review.coreboot.org/c/coreboot/+/36081/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36081/2//COMMIT_MSG@7 PS2, Line 7: vendorcode/amd/agesa/f16kb/Proc/Mem/Feat/DMI
This can be shortened to something like vc/amd/agesa/f16kb
Done
https://review.coreboot.org/c/coreboot/+/36081/2//COMMIT_MSG@10 PS2, Line 10: UINT64_t
UINT64 to be consistent.
Done
https://review.coreboot.org/c/coreboot/+/36081/4/src/vendorcode/amd/agesa/f1... File src/vendorcode/amd/agesa/f16kb/Proc/Mem/Feat/DMI/mfDMI.c:
https://review.coreboot.org/c/coreboot/+/36081/4/src/vendorcode/amd/agesa/f1... PS4, Line 719: DctMemSize
I don't think a DTC on this platform manage 64G of dram, so you could add a sanity check instead of […]
Doesn't hurt to line up your types though.