Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43571 )
Change subject: mb/system76/lemp9/gpio: 2/2 Convert field macros to PAD_CFG ......................................................................
Patch Set 3:
(2 comments)
Patch Set 3:
(2 comments)
I am currently reworking this by checking schematics and board. Can we agree on dropping this one?
yes, sure. no problem
https://review.coreboot.org/c/coreboot/+/43571/3/src/mainboard/system76/lemp... File src/mainboard/system76/lemp9/gpio.h:
https://review.coreboot.org/c/coreboot/+/43571/3/src/mainboard/system76/lemp... PS3, Line 92: PAD_CFG_GPI_APIC(GPP_A11, NONE, PLTRST),
I wonder, how that even passes buildbot... […]
I added SOC_INTEL_COMMON_BLOCK_GPIO_LEGACY_MACROS to local Kconfig so it builds. Yes, we can also use PAD_CFG_GPI_APIC_HIGH(pad, pull, rst) here.
https://review.coreboot.org/c/coreboot/+/43571/3/src/mainboard/system76/lemp... PS3, Line 143: PAD_CFG_GPI_APIC
For context: System76 did some fixes for this board downstream [1], but they haven't been upstreamed […]
Ok, understood. Thanks