Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42226 )
Change subject: mb/google/zork: Enable psp_verstage ......................................................................
Patch Set 9:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42226/5/src/mainboard/google/zork/K... File src/mainboard/google/zork/Kconfig:
https://review.coreboot.org/c/coreboot/+/42226/5/src/mainboard/google/zork/K... PS5, Line 154: default y if VBOOT
Do we want to make this default or select it in our chromium configs?
I think we want to make it the default. I was thinking we'd remove the bootblock option for zork relatively soon.
https://review.coreboot.org/c/coreboot/+/42226/5/src/mainboard/google/zork/K... PS5, Line 162: select VBOOT_SEPARATE_VERSTAGE
shouldn't we be selecting this for VBOOT_STARTS_BEFORE_BOOTBLOCK as well?
It automatically gets selected by selecting VBOOT_STARTS_BEFORE_BOOTBLOCK, so there's no need to do it here.