Attention is currently required from: Maciej Pijanowski, Michał Kopeć.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80609?usp=email )
Change subject: mb/lenovo/m920q: add board ......................................................................
Patch Set 3:
(5 comments)
File src/mainboard/lenovo/m920q/devicetree.cb:
PS3: Move the options into the scope of the related controllers
PS3: Remove options which are disabled
File src/mainboard/lenovo/m920q/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/80609/comment/b84cd215_7d478806 : PS3, Line 16: // global NVS and variables Remove superfluous comment
https://review.coreboot.org/c/coreboot/+/80609/comment/fbc7e68c_6276c850 : PS3, Line 19: Scope (_SB) { : Device (PCI0) ``` Device (_SB.PCI0) { ```
File src/mainboard/lenovo/m920q/mainboard.c:
https://review.coreboot.org/c/coreboot/+/80609/comment/26d56ad3_a99c5c04 : PS3, Line 9: static void mainboard_enable(struct device *dev) : { : // nothing? : } : : struct chip_operations mainboard_ops = { : .enable_dev = mainboard_enable, : }; : Move this into ramstage.c and do the GPIO configuration in mainboard_enable(). mainboard_silicon_init_params() is not supposed to do that since it runs before the FSP is executed and the FSP reconfigures GPIOs.