Attention is currently required from: Julius Werner.
jacz@semihalf.com has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46458 )
Change subject: tests: Add lib/imd_cbmem-test test case
......................................................................
Patch Set 11:
(1 comment)
File tests/lib/imd_cbmem-test.c:
https://review.coreboot.org/c/coreboot/+/46458/comment/f26ff7b6_9d5e046a
PS11, Line 543: memcpy(cbmem_buffer, get_cbmem_ptr(), CBMEM_SIZE);
Yes, storing this as a separate file sounds good as well. […]
Ok, I dumped it to separate file in tests includes.
Also I changed setup to pass aligned memory to CBMEM. CBMEM is aligning its entries but malloc() was returning not aligned addresses and because of that test_general_data_structure() would randomly fail.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46458
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie893b5e8fc91c230ff96a14146085de16d78b1c1
Gerrit-Change-Number: 46458
Gerrit-PatchSet: 11
Gerrit-Owner: jacz@semihalf.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jan Dabros
jsd@semihalf.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Fri, 15 Jan 2021 13:24:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: jacz@semihalf.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment