Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41765 )
Change subject: mb/google/waddledee: Enable Audio
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41765/2/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/waddledee/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/41765/2/src/mainboard/google/dedede...
PS2, Line 61: 1
How is this 1 translate to HP_INT_ODL i.e. GPP_D16?
https://review.coreboot.org/c/coreboot/+/41765/2/src/mainboard/google/dedede...
PS2, Line 67: register "uid" = "0"
Can you please check if EN_SPK gpio needs to be configured. That GPIO is routed to SDB pin in the AMP. Same comment for right side AMP.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41765
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I77aaa27bb29460ef834c3dd090ced868f2e99616
Gerrit-Change-Number: 41765
Gerrit-PatchSet: 2
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Kirtika Ruchandani
kirtika@google.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Uday M Bhat
Gerrit-Reviewer: Yong Zhi
yong.zhi@intel.com
Gerrit-Comment-Date: Wed, 24 Jun 2020 15:41:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment