Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42022 )
Change subject: mb/facebook/watson: support firmware version ......................................................................
Patch Set 2: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/42022/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42022/2//COMMIT_MSG@7 PS2, Line 7: mb/facebook/watson: support firmware version It’d be nice to have *SMBIOS* in there:
Set SMBIOS firmware version
Populate …
https://review.coreboot.org/c/coreboot/+/42022/2/src/mainboard/facebook/wats... File src/mainboard/facebook/watson/ramstage.c:
https://review.coreboot.org/c/coreboot/+/42022/2/src/mainboard/facebook/wats... PS2, Line 16: */ Use SPDX header?
https://review.coreboot.org/c/coreboot/+/42022/2/src/mainboard/facebook/wats... PS2, Line 29: * firmware version. Re-flow for 80 or 96 characters to fit in two lines?