Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46358 )
Change subject: soc/intel/broadwell/romstage/romstage.c: Clean up includes ......................................................................
Patch Set 7:
(2 comments)
Not sure what the rules to clean up are here.
https://review.coreboot.org/c/coreboot/+/46358/7/src/soc/intel/broadwell/rom... File src/soc/intel/broadwell/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/46358/7/src/soc/intel/broadwell/rom... PS7, Line 8: #include <timestamp.h> If you want to simply sort it, please alphabetical.
https://review.coreboot.org/c/coreboot/+/46358/7/src/soc/intel/broadwell/rom... PS7, Line 14: #include <stdint.h> It hurts my OCD to see standard headers at the end :-/