Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36754 )
Change subject: sb/intel/i82801gx: Add common early code
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36754/5/src/southbridge/intel/i8280...
File src/southbridge/intel/i82801gx/early_init.c:
https://review.coreboot.org/c/coreboot/+/36754/5/src/southbridge/intel/i8280...
PS5, Line 71: #if ENV_ROMSTAGE
what's the harm in always having the function built (and gc'd by the linker)?
I don't remember. Possibly it's just the gpio code not being compiled in bootblock.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36754
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie39549938891e17667a8819b49a78b9c71c8ec9e
Gerrit-Change-Number: 36754
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-Comment-Date: Wed, 13 Nov 2019 09:46:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Gerrit-MessageType: comment