Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31858 )
Change subject: mb/google/hatch: Query the EC for board version
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/31858/3/src/mainboard/google/hatch/Kconfig
File src/mainboard/google/hatch/Kconfig:
https://review.coreboot.org/#/c/31858/3/src/mainboard/google/hatch/Kconfig@1...
PS3, Line 19: select EC_GOOGLE_CHROMEEC_BOARDID
: select GOOGLE_SMBIOS_MAINBOARD_VERSION
Can you please arrange this in alphabetical order?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31858
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4bc1cac43c6cf73522f3a4bee89cc000a430d996
Gerrit-Change-Number: 31858
Gerrit-PatchSet: 3
Gerrit-Owner: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Comment-Date: Tue, 12 Mar 2019 14:54:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment