Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45914 )
Change subject: nb/intel/i945/memmap.c: Use `postcar_enable_tseg_cache` ......................................................................
nb/intel/i945/memmap.c: Use `postcar_enable_tseg_cache`
Also correct comments and clean up cosmetics of this function.
Change-Id: I5f3720c02875f546f9dad4bb5582e97d91d39c0d Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/i945/memmap.c 1 file changed, 5 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/45914/1
diff --git a/src/northbridge/intel/i945/memmap.c b/src/northbridge/intel/i945/memmap.c index c92e466..af32f39 100644 --- a/src/northbridge/intel/i945/memmap.c +++ b/src/northbridge/intel/i945/memmap.c @@ -85,11 +85,10 @@ { uintptr_t top_of_ram;
- /* Cache 8 MiB region below the top of RAM and 2 MiB above top of - * RAM to cover both cbmem as the TSEG region. - */ + /* Cache 8 MiB region below the top of RAM to cover CBMEM */ top_of_ram = (uintptr_t)cbmem_top(); - postcar_frame_add_mtrr(pcf, top_of_ram - 8*MiB, 8*MiB, MTRR_TYPE_WRBACK); - postcar_frame_add_mtrr(pcf, northbridge_get_tseg_base(), - northbridge_get_tseg_size(), MTRR_TYPE_WRBACK); + postcar_frame_add_mtrr(pcf, top_of_ram - 8 * MiB, 8 * MiB, MTRR_TYPE_WRBACK); + + /* Cache the TSEG region */ + postcar_enable_tseg_cache(pcf); }