Attention is currently required from: Arthur Heymans, Christian Walter, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Naresh Solanki, Patrick Rudolph, Tim Chu.
Martin L Roth has posted comments on this change by Naresh Solanki. ( https://review.coreboot.org/c/coreboot/+/84741?usp=email )
Change subject: soc/intel/xeon_sp: Allow Memory POR independent of RMT
......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/xeon_sp/spr/Kconfig:
https://review.coreboot.org/c/coreboot/+/84741/comment/ca8fe454_5e770e3e?usp... :
PS2, Line 177: MEM_POR_FREQ
This could be FORCE_MEM_POR.
FREQ isn't accurate since it enforces voltage as well, and when you see it in the code "MEM_POR_FREQ" doesn't tell you what it does. For all we can tell, it could mean "relax mem por".
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84741?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4341ead89a2683f64c834a6981ba316fcfef4f9a
Gerrit-Change-Number: 84741
Gerrit-PatchSet: 3
Gerrit-Owner: Naresh Solanki
naresh.solanki@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Naresh Solanki
naresh.solanki@9elements.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Wed, 16 Oct 2024 15:26:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No