[coreboot-gerrit] New patch to review for coreboot: libpayload/.../PDCurses: better compatibility with ncurses

[Patrick Georgi]

Patrick Georgi ([e-mail]) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17836

-gerrit

commit 4eec3ca15da4105bdcdea92ec659af7ec030e052
Author: Patrick Georgi 
Date:   Tue Dec 13 15:50:23 2016 +0100

libpayload/.../PDCurses: better compatibility with ncurses

Coverity erroneously complains that we call wmove with x or y == -1,
    even though our copy of that function properly checks for that.

But: setsyx is documented to always return OK (even on errors), so let
    it do that. (and make coverity happy in the process)

Change-Id: I1bc9ba2a075037f0e1a855b67a93883978564887
    Signed-off-by: Patrick Georgi 
    Found-by: Coverity Scan #1260797
---
 payloads/libpayload/curses/PDCurses/pdcurses/getyx.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/payloads/libpayload/curses/PDCurses/pdcurses/getyx.c b/payloads/libpayload/curses/PDCurses/pdcurses/getyx.c
index 1c03917..0f39c48 100644
--- a/payloads/libpayload/curses/PDCurses/pdcurses/getyx.c
+++ b/payloads/libpayload/curses/PDCurses/pdcurses/getyx.c
@@ -135,9 +135,14 @@ int setsyx(int y, int x)
         curscr->_leaveit = TRUE;
         return OK;
     }
+    else if (y == -1 || x == -1)
+    {
+        return OK;
+    }
     else
     {
         curscr->_leaveit = FALSE;
-        return wmove(curscr, y, x);
+        wmove(curscr, y, x);
+	return OK;
     }
 }