Attention is currently required from: Christian Walter.
Benjamin Doron has posted comments on this change by Christian Walter. ( https://review.coreboot.org/c/coreboot/+/82235?usp=email )
Change subject: src/drivers/vpd: Add VPD as option backend ......................................................................
Patch Set 2:
(3 comments)
File src/drivers/vpd/Kconfig:
https://review.coreboot.org/c/coreboot/+/82235/comment/54058343_b90d2e77?usp... : PS2, Line 28: config VPD_OPTION_BACKEND Use this Kconfig to determine in VPD's Makefile if options.c is compiled in? Although somewhere in https://github.com/coreboot/coreboot/blob/8d0d57f0a2ed454f0036caae6d6ac30c5e... may be a better place for this anyways.
File src/drivers/vpd/options.c:
https://review.coreboot.org/c/coreboot/+/82235/comment/3d9734f4_7a2abe0c?usp... : PS2, Line 1: BSD-3-Clause coreboot tends towards GPL v2, or GPL v2+. Is BSD allowed?
https://review.coreboot.org/c/coreboot/+/82235/comment/3ce8a4e8_fea7c749?usp... : PS2, Line 19: printk(BIOS_WARNING, "VPDs are not meant to be written from coreboot", name, value); The arguments are unused, and this is missing a newline character. Perhaps `"Attempted to write "%s" = %d. VPDs should not be written from coreboot, skipping\n"`