Attention is currently required from: Bob Moragues, Karthik Ramasubramanian, Nick Vaccaro.
Subrata Banik has posted comments on this change by Karthik Ramasubramanian. ( https://review.coreboot.org/c/coreboot/+/83984?usp=email )
Change subject: mb/google/brox: Enable storage devices on unprovisioned fw_config
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
That needs provisioning the FW_CONFIG with value 0 or whatever is equivalent to STORAGE_UNKNOWN. As more devices are built during the later hardware build phases, this is going to be hard to provision the FW_CONFIG with that special value. Also that takes away a field option unnecessarily.
With this change, the plan is to get rid of STORAGE_UNKNOWN.
I think this is a good plan, especially since we're currently working on Intel RVP. My only concern is that all devices are running from the FW branch, and I hope they don't need to adhere to this new change. Going forward, we should use this new norm for all CrOS devices.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83984?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0537f7d1d83293b9b3408f0aadf11fa2e7908163
Gerrit-Change-Number: 83984
Gerrit-PatchSet: 2
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Bob Moragues
moragues@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Ren Kuo
ren.kuo@quantatw.com
Gerrit-Attention: Bob Moragues
moragues@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Tue, 20 Aug 2024 17:34:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com