Attention is currently required from: Cliff Huang, Selma Bensaid, Patrick Rudolph. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62653 )
Change subject: src/cpu/intel/common: Add support for energy performance preference (EPP) ......................................................................
Patch Set 1:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62653/comment/2a58b57b_75112d68 PS1, Line 7: src/cpu/intel/common `cpu/intel/common`
https://review.coreboot.org/c/coreboot/+/62653/comment/58ccade8_23c950ee PS1, Line 12: BRANCH=firmware : BRANCH=firmware-brya-14505.Bre-brya-14505.B `BRANCH=firmware-brya-14505.B`
File src/cpu/intel/common/common_init.c:
https://review.coreboot.org/c/coreboot/+/62653/comment/1a37be8f_0d1580d0 PS1, Line 12: #define CPUID_6_ENGERY_PERF_PREF (1<<10) : #define CPUID_6_HWP (1<<7) nit: make sure these all line up on the right side
https://review.coreboot.org/c/coreboot/+/62653/comment/f1c233bb_1862e0fc PS1, Line 212: HWP_ENABLE maybe a more informative message here, e.g. `Enabling energy-perf preference in favor of energy-perf bias` ?
File src/include/cpu/x86/msr.h:
https://review.coreboot.org/c/coreboot/+/62653/comment/f94fe1f6_e9522481 PS1, Line 88: #define IA32_PM_ENABLE 0x770 : #define HWP_ENABLE 0x1 : #define IA32_HWP_CAPABILITIES 0x771 : #define IA32_HWP_REQUEST 0x774 : #define IA32_HWP_REQUEST_EPP_MASK 0xff000000 : #define IA32_HWP_REQUEST_EPP_SHIFT 24 nit: make sure these all line up on the right side