Attention is currently required from: Angel Pons, Arthur Heymans, Elyes Haouas, Felix Held.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69339 )
Change subject: Revert "mb/aopen/dxplplusu: Remove board" ......................................................................
Patch Set 1:
(143 comments)
File src/mainboard/aopen/dxplplusu/acpi_tables.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/35a39aa3_2588eda5 PS1, Line 21: struct resource* res = NULL; "foo* bar" should be "foo *bar"
File src/northbridge/intel/e7505/northbridge.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/46872d33_38e4d1a6 PS1, Line 76: if (dev->path.type == DEVICE_PATH_DOMAIN) { braces {} are not necessary for any arm of this statement
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/e26889c0_647c5eff PS1, Line 79: else if (dev->path.type == DEVICE_PATH_CPU_CLUSTER) { else should follow close brace '}'
File src/northbridge/intel/e7505/raminit.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/0e6a3cb9_123e1c2b PS1, Line 175: while (i--) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/e6726d7a_16b3fef2 PS1, Line 357: hw_err: labels should not be indented
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/1a07b301_a05775c3 PS1, Line 696: BUG(); Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/1bb837f3_0d911207 PS1, Line 994: hw_err: labels should not be indented
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/0a1d9e01_93e18e5c PS1, Line 1159: mem_controller *ctrl, need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/392c6407_dc96d412 PS1, Line 1189: if (!(dimm_mask & (1 << i))) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/afa7be33_7a9e49d6 PS1, Line 1206: if (value != ERROR_SCHEME_ECC) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/98564d67_707ddbb5 PS1, Line 1276: if (sdram_width.side1 == 4) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/11ee3eae_ec4b5a92 PS1, Line 1280: if (sdram_width.side2 == 4) { braces {} are not necessary for single statement blocks
File src/southbridge/intel/i82801dx/ac97.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/cd872960_2986db66 PS1, Line 85: if (! timeout) { space prohibited after that '!' (ctx:BxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/04365e56_d049e805 PS1, Line 85: if (! timeout) { braces {} are not necessary for single statement blocks
File src/southbridge/intel/i82801dx/i82801dx.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/aa637b3c_78aa1181 PS1, Line 92: #define RTC_FAILED (1 <<2) need consistent spacing around '<<' (ctx:WxV)
File src/southbridge/intel/i82801dx/i82801dx.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/fc1ac73a_ce95bfa8 PS1, Line 55: if (!dev->enabled) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/e2ba28c5_98079f62 PS1, Line 58: if (new_disable_mask != cur_disable_mask) { braces {} are not necessary for single statement blocks
File src/southbridge/intel/i82801dx/lpc.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/b453fc8b_42ed5aca PS1, Line 99: switch (pwr_on) { switch and case should be at the same indent
File src/southbridge/intel/i82801dx/smi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/caec032e_130ccc2d PS1, Line 47: if (pm1_sts & (1 << 15)) printk(BIOS_DEBUG, "WAK "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/b5db6f45_d2051f7f PS1, Line 48: if (pm1_sts & (1 << 14)) printk(BIOS_DEBUG, "PCIEXPWAK "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/c315739f_e84a201e PS1, Line 49: if (pm1_sts & (1 << 11)) printk(BIOS_DEBUG, "PRBTNOR "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/aef5fd96_2a339267 PS1, Line 50: if (pm1_sts & (1 << 10)) printk(BIOS_DEBUG, "RTC "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/b6899f43_af5bfeaf PS1, Line 51: if (pm1_sts & (1 << 8)) printk(BIOS_DEBUG, "PWRBTN "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/ad9e7cbd_40d1129c PS1, Line 52: if (pm1_sts & (1 << 5)) printk(BIOS_DEBUG, "GBL "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/05023e6f_810d1ef3 PS1, Line 53: if (pm1_sts & (1 << 4)) printk(BIOS_DEBUG, "BM "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/e8682069_4c5de9dc PS1, Line 54: if (pm1_sts & (1 << 0)) printk(BIOS_DEBUG, "TMROF "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/5739443e_ca42774e PS1, Line 76: if (smi_sts & (1 << 26)) printk(BIOS_DEBUG, "SPI "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/465e49bf_bfd51369 PS1, Line 77: if (smi_sts & (1 << 25)) printk(BIOS_DEBUG, "EL_SMI "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/221796f3_df781d07 PS1, Line 78: if (smi_sts & (1 << 21)) printk(BIOS_DEBUG, "MONITOR "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/80e1972f_c374bebd PS1, Line 79: if (smi_sts & (1 << 20)) printk(BIOS_DEBUG, "PCI_EXP_SMI "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/01716bef_5deadb03 PS1, Line 80: if (smi_sts & (1 << 18)) printk(BIOS_DEBUG, "INTEL_USB2 "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/5df9d3fd_6bb0f320 PS1, Line 81: if (smi_sts & (1 << 17)) printk(BIOS_DEBUG, "LEGACY_USB2 "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/adcf04f1_d46c00c2 PS1, Line 82: if (smi_sts & (1 << 16)) printk(BIOS_DEBUG, "SMBUS_SMI "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/e5469d8c_6e9b2660 PS1, Line 83: if (smi_sts & (1 << 15)) printk(BIOS_DEBUG, "SERIRQ_SMI "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/bd710b99_30cb3f05 PS1, Line 84: if (smi_sts & (1 << 14)) printk(BIOS_DEBUG, "PERIODIC "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/7784aa21_809793ea PS1, Line 85: if (smi_sts & (1 << 13)) printk(BIOS_DEBUG, "TCO "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/4604e1d7_84b51581 PS1, Line 86: if (smi_sts & (1 << 12)) printk(BIOS_DEBUG, "DEVMON "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/5bb57034_dc667498 PS1, Line 87: if (smi_sts & (1 << 11)) printk(BIOS_DEBUG, "MCSMI "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/71bdc203_b8e08a9b PS1, Line 88: if (smi_sts & (1 << 10)) printk(BIOS_DEBUG, "GPI "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/ad42da81_f671f4fd PS1, Line 89: if (smi_sts & (1 << 9)) printk(BIOS_DEBUG, "GPE0 "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/0605ffa8_184a3163 PS1, Line 90: if (smi_sts & (1 << 8)) printk(BIOS_DEBUG, "PM1 "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/b0c0186e_115cde9b PS1, Line 91: if (smi_sts & (1 << 6)) printk(BIOS_DEBUG, "SWSMI_TMR "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/309a8c81_7c2055d9 PS1, Line 92: if (smi_sts & (1 << 5)) printk(BIOS_DEBUG, "APM "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/b4710171_ed694264 PS1, Line 93: if (smi_sts & (1 << 4)) printk(BIOS_DEBUG, "SLP_SMI "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/c92a5d70_01705ecc PS1, Line 94: if (smi_sts & (1 << 3)) printk(BIOS_DEBUG, "LEGACY_USB "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/9166dd88_197e9539 PS1, Line 95: if (smi_sts & (1 << 2)) printk(BIOS_DEBUG, "BIOS "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/5d53aad6_eaad613f PS1, Line 118: for (i=31; i>= 16; i--) { spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/c1fe3db8_7fd19b9e PS1, Line 118: for (i=31; i>= 16; i--) { spaces required around that '>=' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/9fbcb733_0e966762 PS1, Line 119: if (gpe0_sts & (1 << i)) printk(BIOS_DEBUG, "GPIO%d ", (i-16)); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/371978e3_130bdc90 PS1, Line 121: if (gpe0_sts & (1 << 14)) printk(BIOS_DEBUG, "USB4 "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/e1aedd64_7da30005 PS1, Line 122: if (gpe0_sts & (1 << 13)) printk(BIOS_DEBUG, "PME_B0 "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/2326313d_9d327d34 PS1, Line 123: if (gpe0_sts & (1 << 12)) printk(BIOS_DEBUG, "USB3 "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/75817efd_3becb3a4 PS1, Line 124: if (gpe0_sts & (1 << 11)) printk(BIOS_DEBUG, "PME "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/bba4cb28_36ca8078 PS1, Line 125: if (gpe0_sts & (1 << 10)) printk(BIOS_DEBUG, "EL_SCI/BATLOW "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/87343a84_a9f3991e PS1, Line 126: if (gpe0_sts & (1 << 9)) printk(BIOS_DEBUG, "PCI_EXP "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/e22d3a51_af5be3cd PS1, Line 127: if (gpe0_sts & (1 << 8)) printk(BIOS_DEBUG, "RI "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/3f7d6bd8_02b1ece5 PS1, Line 128: if (gpe0_sts & (1 << 7)) printk(BIOS_DEBUG, "SMB_WAK "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/4c52b6a7_5eb6ddf4 PS1, Line 129: if (gpe0_sts & (1 << 6)) printk(BIOS_DEBUG, "TCO_SCI "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/af535799_72e7fe1b PS1, Line 130: if (gpe0_sts & (1 << 5)) printk(BIOS_DEBUG, "AC97 "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/7ad76a1d_63915aef PS1, Line 131: if (gpe0_sts & (1 << 4)) printk(BIOS_DEBUG, "USB2 "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/534130ac_2cfef843 PS1, Line 132: if (gpe0_sts & (1 << 3)) printk(BIOS_DEBUG, "USB1 "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/e89028c4_dac652af PS1, Line 133: if (gpe0_sts & (1 << 2)) printk(BIOS_DEBUG, "HOT_PLUG "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/7916100c_fb1d9400 PS1, Line 134: if (gpe0_sts & (1 << 0)) printk(BIOS_DEBUG, "THRM "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/7f917588_f01fd45c PS1, Line 157: for (i=15; i>= 0; i--) { spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/2bae363b_458aee50 PS1, Line 157: for (i=15; i>= 0; i--) { spaces required around that '>=' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/93ef48db_8fcdbe4a PS1, Line 158: if (alt_gp_smi_sts & (1 << i)) printk(BIOS_DEBUG, "GPI%d ", i); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/4d02ff31_0d02c30d PS1, Line 184: if (tco_sts & (1 << 20)) printk(BIOS_DEBUG, "SMLINK_SLV "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/4a6139f3_dd2063db PS1, Line 185: if (tco_sts & (1 << 18)) printk(BIOS_DEBUG, "BOOT "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/85e87420_b609bb33 PS1, Line 186: if (tco_sts & (1 << 17)) printk(BIOS_DEBUG, "SECOND_TO "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/f1d32a8e_c2a55c5a PS1, Line 187: if (tco_sts & (1 << 16)) printk(BIOS_DEBUG, "INTRD_DET "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/9301738a_1beccf99 PS1, Line 188: if (tco_sts & (1 << 12)) printk(BIOS_DEBUG, "DMISERR "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/5daf2ed3_83609d8e PS1, Line 189: if (tco_sts & (1 << 10)) printk(BIOS_DEBUG, "DMISMI "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/c36190de_3e1cec13 PS1, Line 190: if (tco_sts & (1 << 9)) printk(BIOS_DEBUG, "DMISCI "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/25fed2e1_55743d2a PS1, Line 191: if (tco_sts & (1 << 8)) printk(BIOS_DEBUG, "BIOSWR "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/9c357152_27040432 PS1, Line 192: if (tco_sts & (1 << 7)) printk(BIOS_DEBUG, "NEWCENTURY "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/a465c251_4ed6d307 PS1, Line 193: if (tco_sts & (1 << 3)) printk(BIOS_DEBUG, "TIMEOUT "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/0c1ea799_f1f6924f PS1, Line 194: if (tco_sts & (1 << 2)) printk(BIOS_DEBUG, "TCO_INT "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/61f3efb6_c7cbf1b5 PS1, Line 195: if (tco_sts & (1 << 1)) printk(BIOS_DEBUG, "SW_TCO "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/93ad79f3_582c2de8 PS1, Line 196: if (tco_sts & (1 << 0)) printk(BIOS_DEBUG, "NMI2SMI "); trailing statements should be on next line
File src/southbridge/intel/i82801dx/smihandler.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/976a0f35_46a827cf PS1, Line 45: if (pm1_sts & (1 << 15)) printk(BIOS_SPEW, "WAK "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/a8de9ab9_079abe18 PS1, Line 46: if (pm1_sts & (1 << 14)) printk(BIOS_SPEW, "PCIEXPWAK "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/aab48c78_1ceaec00 PS1, Line 47: if (pm1_sts & (1 << 11)) printk(BIOS_SPEW, "PRBTNOR "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/bdcffe58_0485ca18 PS1, Line 48: if (pm1_sts & (1 << 10)) printk(BIOS_SPEW, "RTC "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/09834c4d_9404886f PS1, Line 49: if (pm1_sts & (1 << 8)) printk(BIOS_SPEW, "PWRBTN "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/1885b5c3_2bd6e4ce PS1, Line 50: if (pm1_sts & (1 << 5)) printk(BIOS_SPEW, "GBL "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/2822868e_e2643dfb PS1, Line 51: if (pm1_sts & (1 << 4)) printk(BIOS_SPEW, "BM "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/3e94d97d_8ab2577a PS1, Line 52: if (pm1_sts & (1 << 0)) printk(BIOS_SPEW, "TMROF "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/55ab1bec_cda151c4 PS1, Line 76: if (smi_sts & (1 << 26)) printk(BIOS_DEBUG, "SPI "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/d62a3ade_59f121a5 PS1, Line 77: if (smi_sts & (1 << 25)) printk(BIOS_DEBUG, "EL_SMI "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/533c2b26_33b911a1 PS1, Line 78: if (smi_sts & (1 << 21)) printk(BIOS_DEBUG, "MONITOR "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/11c7456b_ac39b2bc PS1, Line 79: if (smi_sts & (1 << 20)) printk(BIOS_DEBUG, "PCI_EXP_SMI "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/0c942903_65eb4b2a PS1, Line 80: if (smi_sts & (1 << 18)) printk(BIOS_DEBUG, "INTEL_USB2 "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/53b0fbd1_f65801bf PS1, Line 81: if (smi_sts & (1 << 17)) printk(BIOS_DEBUG, "LEGACY_USB2 "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/7c38c1ce_2c5f67d5 PS1, Line 82: if (smi_sts & (1 << 16)) printk(BIOS_DEBUG, "SMBUS_SMI "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/00538ed9_020bb7c8 PS1, Line 83: if (smi_sts & (1 << 15)) printk(BIOS_DEBUG, "SERIRQ_SMI "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/3287408e_081645d1 PS1, Line 84: if (smi_sts & (1 << 14)) printk(BIOS_DEBUG, "PERIODIC "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/e6a7771c_ba877c38 PS1, Line 85: if (smi_sts & (1 << 13)) printk(BIOS_DEBUG, "TCO "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/9569e08c_2ae1219f PS1, Line 86: if (smi_sts & (1 << 12)) printk(BIOS_DEBUG, "DEVMON "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/b2062b49_0b70e76d PS1, Line 87: if (smi_sts & (1 << 11)) printk(BIOS_DEBUG, "MCSMI "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/bc03c79c_ee13bf88 PS1, Line 88: if (smi_sts & (1 << 10)) printk(BIOS_DEBUG, "GPI "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/c4ee84b6_31129edc PS1, Line 89: if (smi_sts & (1 << 9)) printk(BIOS_DEBUG, "GPE0 "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/4c872f82_c2594cfb PS1, Line 90: if (smi_sts & (1 << 8)) printk(BIOS_DEBUG, "PM1 "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/52a2f293_43bca4df PS1, Line 91: if (smi_sts & (1 << 6)) printk(BIOS_DEBUG, "SWSMI_TMR "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/392434a7_d918ab4a PS1, Line 92: if (smi_sts & (1 << 5)) printk(BIOS_DEBUG, "APM "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/e89b97b1_764e586b PS1, Line 93: if (smi_sts & (1 << 4)) printk(BIOS_DEBUG, "SLP_SMI "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/cfb7b2dd_b03bf020 PS1, Line 94: if (smi_sts & (1 << 3)) printk(BIOS_DEBUG, "LEGACY_USB "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/7c3879b3_c8126764 PS1, Line 95: if (smi_sts & (1 << 2)) printk(BIOS_DEBUG, "BIOS "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/473ca6c6_94b1b5c5 PS1, Line 118: for (i=31; i>= 16; i--) { spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/cf0209ad_cf87bb97 PS1, Line 118: for (i=31; i>= 16; i--) { spaces required around that '>=' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/ff07a77a_c8f0a533 PS1, Line 119: if (gpe0_sts & (1 << i)) printk(BIOS_DEBUG, "GPIO%d ", (i-16)); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/9aa76e3b_56a089a6 PS1, Line 121: if (gpe0_sts & (1 << 14)) printk(BIOS_DEBUG, "USB4 "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/4b8997bd_85f0b492 PS1, Line 122: if (gpe0_sts & (1 << 13)) printk(BIOS_DEBUG, "PME_B0 "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/dc7e754d_3ab15d4f PS1, Line 123: if (gpe0_sts & (1 << 12)) printk(BIOS_DEBUG, "USB3 "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/07afde12_31e8dd2c PS1, Line 124: if (gpe0_sts & (1 << 11)) printk(BIOS_DEBUG, "PME "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/82a172ef_7dc3e21c PS1, Line 125: if (gpe0_sts & (1 << 10)) printk(BIOS_DEBUG, "EL_SCI/BATLOW "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/77033bae_747530ee PS1, Line 126: if (gpe0_sts & (1 << 9)) printk(BIOS_DEBUG, "PCI_EXP "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/e8e828b9_3aa3779a PS1, Line 127: if (gpe0_sts & (1 << 8)) printk(BIOS_DEBUG, "RI "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/e5349fb9_0acb4880 PS1, Line 128: if (gpe0_sts & (1 << 7)) printk(BIOS_DEBUG, "SMB_WAK "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/0c238514_2472eb92 PS1, Line 129: if (gpe0_sts & (1 << 6)) printk(BIOS_DEBUG, "TCO_SCI "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/79680878_07eabfcc PS1, Line 130: if (gpe0_sts & (1 << 5)) printk(BIOS_DEBUG, "AC97 "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/dd2828ae_02e22495 PS1, Line 131: if (gpe0_sts & (1 << 4)) printk(BIOS_DEBUG, "USB2 "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/2b3868f3_52dcbc0e PS1, Line 132: if (gpe0_sts & (1 << 3)) printk(BIOS_DEBUG, "USB1 "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/413522e8_e24fb3ca PS1, Line 133: if (gpe0_sts & (1 << 2)) printk(BIOS_DEBUG, "HOT_PLUG "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/00203e2c_8c54fd32 PS1, Line 134: if (gpe0_sts & (1 << 0)) printk(BIOS_DEBUG, "THRM "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/ac2ad35b_d5b11ca0 PS1, Line 159: if (tco_sts & (1 << 20)) printk(BIOS_DEBUG, "SMLINK_SLV "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/0fe2985c_57d97c22 PS1, Line 160: if (tco_sts & (1 << 18)) printk(BIOS_DEBUG, "BOOT "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/0df30214_a116a97f PS1, Line 161: if (tco_sts & (1 << 17)) printk(BIOS_DEBUG, "SECOND_TO "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/91c6443e_e74eaedb PS1, Line 162: if (tco_sts & (1 << 16)) printk(BIOS_DEBUG, "INTRD_DET "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/6fad6113_26254fda PS1, Line 163: if (tco_sts & (1 << 12)) printk(BIOS_DEBUG, "DMISERR "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/be77c582_fd95185f PS1, Line 164: if (tco_sts & (1 << 10)) printk(BIOS_DEBUG, "DMISMI "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/6d1cccf6_1d20bf9e PS1, Line 165: if (tco_sts & (1 << 9)) printk(BIOS_DEBUG, "DMISCI "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/c1d77d1c_a95af920 PS1, Line 166: if (tco_sts & (1 << 8)) printk(BIOS_DEBUG, "BIOSWR "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/890923c0_bed3340d PS1, Line 167: if (tco_sts & (1 << 7)) printk(BIOS_DEBUG, "NEWCENTURY "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/d2165ed6_b6941765 PS1, Line 168: if (tco_sts & (1 << 3)) printk(BIOS_DEBUG, "TIMEOUT "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/be329fe1_ce24ca2a PS1, Line 169: if (tco_sts & (1 << 2)) printk(BIOS_DEBUG, "TCO_INT "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/a5716d5a_07069efe PS1, Line 170: if (tco_sts & (1 << 1)) printk(BIOS_DEBUG, "SW_TCO "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/8ccd30bf_05240144 PS1, Line 171: if (tco_sts & (1 << 0)) printk(BIOS_DEBUG, "NMI2SMI "); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/6e3dcc8e_acb862c5 PS1, Line 247: case ACPI_S0: printk(BIOS_DEBUG, "SMI#: Entering S0 (On)\n"); break; trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/27a5083e_82577514 PS1, Line 248: case ACPI_S1: printk(BIOS_DEBUG, "SMI#: Entering S1 (Assert STPCLK#)\n"); break; trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/b9385fac_a822a665 PS1, Line 254: case ACPI_S4: printk(BIOS_DEBUG, "SMI#: Entering S4 (Suspend-To-Disk)\n"); break; trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/65f05dd3_561c03b4 PS1, Line 274: default: printk(BIOS_DEBUG, "SMI#: ERROR: SLP_TYP reserved\n"); break; trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/4bad630c_1f32a2cd PS1, Line 352: printk(BIOS_DEBUG, "GPI (mask %04x)\n",reg16); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162868): https://review.coreboot.org/c/coreboot/+/69339/comment/88f96fed_5718abf1 PS1, Line 488: if (dump) { braces {} are not necessary for single statement blocks