Attention is currently required from: Tim Crawford, Sean Rhodes, Jeremy Soller, Nick Vaccaro.
Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/72663 )
Change subject: treewide: Remove unuseful "_UID: Unique ID" comment ......................................................................
treewide: Remove unuseful "_UID: Unique ID" comment
Change-Id: I150a4ed94bcaead6eb45f1c4b4952ae6957e0940 Signed-off-by: Elyes Haouas ehaouas@noos.fr --- M src/ec/purism/librem-ec/acpi/battery.asl M src/ec/system76/ec/acpi/battery.asl M src/mainboard/acer/aspire_vn7_572g/acpi/battery.asl M src/mainboard/google/poppy/variants/atlas/include/variant/acpi/cam0.asl M src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/cam0.asl M src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/cam1.asl M src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl M src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/cam0.asl M src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl M src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl M src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl M src/mainboard/google/volteer/variants/voema/include/variant/acpi/mipi_camera.asl M src/mainboard/intel/kblrvp/acpi/mipi_camera.asl M src/mainboard/intel/tglrvp/acpi/mipi_camera.asl M src/mainboard/starlabs/lite/acpi/touchpad.asl M src/mainboard/system76/kbl-u/acpi/battery.asl M src/soc/intel/common/block/acpi/acpi/northbridge.asl M src/soc/intel/skylake/acpi/systemagent.asl 18 files changed, 46 insertions(+), 36 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/72663/1
diff --git a/src/ec/purism/librem-ec/acpi/battery.asl b/src/ec/purism/librem-ec/acpi/battery.asl index 8836c7a..0085225 100644 --- a/src/ec/purism/librem-ec/acpi/battery.asl +++ b/src/ec/purism/librem-ec/acpi/battery.asl @@ -5,7 +5,7 @@ Device (BAT0) { Name (_HID, EisaId ("PNP0C0A") /* Control Method Battery */) - Name (_UID, 0) // _UID: Unique ID + Name (_UID, 0) Name (_PCL, Package (0x01) // _PCL: Power Consumer List { _SB diff --git a/src/ec/system76/ec/acpi/battery.asl b/src/ec/system76/ec/acpi/battery.asl index 64cb370..0c4bf9f 100644 --- a/src/ec/system76/ec/acpi/battery.asl +++ b/src/ec/system76/ec/acpi/battery.asl @@ -3,7 +3,7 @@ Device (BAT0) { Name (_HID, EisaId ("PNP0C0A") /* Control Method Battery */) - Name (_UID, 0) // _UID: Unique ID + Name (_UID, 0) Name (_PCL, Package (0x01) // _PCL: Power Consumer List { _SB diff --git a/src/mainboard/acer/aspire_vn7_572g/acpi/battery.asl b/src/mainboard/acer/aspire_vn7_572g/acpi/battery.asl index a4fa0e7..5395336 100644 --- a/src/mainboard/acer/aspire_vn7_572g/acpi/battery.asl +++ b/src/mainboard/acer/aspire_vn7_572g/acpi/battery.asl @@ -338,7 +338,7 @@ Device (BAT0) { Name (_HID, EisaId ("PNP0C0A") /* Control Method Battery */) - Name (_UID, 0) // _UID: Unique ID + Name (_UID, 0) Name (_PCL, Package () { _SB }) // _PCL: Power Consumer List
Name (B0IP, Package (0x0D) diff --git a/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/cam0.asl b/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/cam0.asl index 726b5b6..9601bf3 100644 --- a/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/cam0.asl +++ b/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/cam0.asl @@ -47,7 +47,7 @@ Device (CAM0) { Name (_HID, "INT3478") - Name (_UID, 0) /* _UID: Unique ID */ + Name (_UID, 0) Name (_DDN, "SONY IMX208 Camera") /* _DDN: DOS Device Name */
Method (_STA, 0, NotSerialized) /* _STA: Status */ @@ -109,7 +109,7 @@ Device (NVM0) { Name (_HID, "INT3499") - Name (_UID, 0) /* _UID: Unique ID */ + Name (_UID, 0) Name (_DDN, "GT24C16S") /* _DDN: DOS Device Name */
Method (_STA, 0, NotSerialized) /* _STA: Status */ diff --git a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/cam0.asl b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/cam0.asl index cc63fc3..a77dbcb 100644 --- a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/cam0.asl +++ b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/cam0.asl @@ -5,7 +5,7 @@ Device (CAM0) { Name (_HID, "OVTID858") - Name (_UID, 0) /* _UID: Unique ID */ + Name (_UID, 0) Name (_DDN, "OV 13858 Camera") /* _DDN: DOS Device Name */ Name (CAMD, 0x02)
@@ -92,7 +92,7 @@ Device (VCM0) { Name (_HID, "PRP0001") - Name (_UID, 0) /* _UID: Unique ID */ + Name (_UID, 0) Name (_DDN, "Dongwoon AF DAC") /* _DDN: DOS Device Name */ Name (CAMD, 0x03)
@@ -124,7 +124,7 @@ Device (NVM0) { Name (_HID, "INT3499") - Name (_UID, 0) /* _UID: Unique ID */ + Name (_UID, 0) Name (_DDN, "GT24C16S/CAT24C16") /* _DDN: DOS Device Name */
Method (_STA, 0, NotSerialized) /* _STA: Status */ diff --git a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/cam1.asl b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/cam1.asl index b8de067..08b2eb6 100644 --- a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/cam1.asl +++ b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/cam1.asl @@ -5,7 +5,7 @@ Device (CAM1) { Name (_HID, "INT3479") - Name (_UID, 0) /* _UID: Unique ID */ + Name (_UID, 0) Name (_DDN, "OV 5670 Camera") /* _DDN: DOS Device Name */ Name (CAMD, 0x02)
diff --git a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl index 6307d26..61611d1 100644 --- a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl +++ b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl @@ -5,7 +5,7 @@ Device (PMIC) { Name (_HID, "INT3472") - Name (_UID, 0) /* _UID: Unique ID */ + Name (_UID, 0) Name (_DDN, "TPS68470 PMIC") /* _DDN: DOS Device Name */ Name (CAMD, 0x64)
diff --git a/src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/cam0.asl b/src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/cam0.asl index c22c580..fd4a05d 100644 --- a/src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/cam0.asl +++ b/src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/cam0.asl @@ -5,7 +5,7 @@ Device (CAM0) { Name (_HID, "SONY258A") - Name (_UID, 0) /* _UID: Unique ID */ + Name (_UID, 0) Name (_DDN, "SONY IMX258 Camera") /* _DDN: DOS Device Name */
Method (_STA, 0, NotSerialized) /* _STA: Status */ @@ -73,7 +73,7 @@ Device (VCM0) { Name (_HID, "PRP0001") - Name (_UID, 0) /* _UID: Unique ID */ + Name (_UID, 0) Name (_DDN, "Dongwoon AF DAC") /* _DDN: DOS Device Name */
Method (_STA, 0, NotSerialized) /* _STA: Status */ @@ -104,7 +104,7 @@ Device (NVM0) { Name (_HID, "INT3499") - Name (_UID, 0) /* _UID: Unique ID */ + Name (_UID, 0) Name (_DDN, "Dongwoon NVM") /* _DDN: DOS Device Name */
Method (_STA, 0, NotSerialized) /* _STA: Status */ diff --git a/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl b/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl index c8fda8e..41ab47a 100644 --- a/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl +++ b/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl @@ -41,7 +41,7 @@ Device (CAM0) { Name (_HID, "SONY319A") - Name (_UID, 0) /* _UID: Unique ID */ + Name (_UID, 0) Name (_DDN, "Sony IMX319 Camera") /* _DDN: DOS Device Name */
Method (_STA, 0, NotSerialized) /* _STA: Status */ @@ -104,7 +104,7 @@ Device (NVM0) { Name (_HID, "INT3499") - Name (_UID, 0) /* _UID: Unique ID */ + Name (_UID, 0) Name (_DDN, "M24C64S") /* _DDN: DOS Device Name */
Method (_STA, 0, NotSerialized) /* _STA: Status */ diff --git a/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl b/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl index 11076e3..1fecd15 100644 --- a/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl +++ b/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl @@ -40,7 +40,7 @@ Device (CAM1) { Name (_HID, "SONY355A") - Name (_UID, 0) /* _UID: Unique ID */ + Name (_UID, 0) Name (_DDN, "SONY IMX355A Camera") /* _DDN: DOS Device Name */
Method (_STA, 0, NotSerialized) /* _STA: Status */ @@ -106,7 +106,7 @@ Device (VCM1) { Name (_HID, "PRP0001") - Name (_UID, 3) /* _UID: Unique ID */ + Name (_UID, 3) Name (_DDN, "AKM AF DAC") /* _DDN: DOS Device Name */
Method (_STA, 0, NotSerialized) /* _STA: Status */ @@ -138,7 +138,7 @@ Device (NVM1) { Name (_HID, "INT3499") - Name (_UID, 1) /* _UID: Unique ID */ + Name (_UID, 1) Name (_DDN, "M24C64S") /* _DDN: DOS Device Name */
Method (_STA, 0, NotSerialized) /* _STA: Status */ diff --git a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl index d8685da..c273f83 100644 --- a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl +++ b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl @@ -208,7 +208,7 @@ Device (CAM0) { Name (_HID, "OVTI8856") - Name (_UID, 0) /* _UID: Unique ID */ + Name (_UID, 0) Name (_DDN, "Ov 8856 Camera") /* _DDN: DOS Device Name */ Method (_STA, 0, NotSerialized) /* _STA: Status */ { @@ -365,7 +365,7 @@ Device (VCM0) { Name (_HID, "PRP0001") - Name (_UID, 0x00) /* _UID: Unique ID */ + Name (_UID, 0x00) Name (_DDN, "DW9768 VCM") /* _DDN: DOS Device Name */ Method (_STA, 0, NotSerialized) /* _STA: Status */ { @@ -411,7 +411,7 @@ Device (NVM0) { Name (_HID, "PRP0001") - Name (_UID, 0x01) // _UID: Unique ID + Name (_UID, 0x01) Name (_DDN, "AT24 EEPROM") // _DDN: DOS Device Name Method (_STA, 0, NotSerialized) // _STA: Status { @@ -534,7 +534,7 @@ Device (CAM1) { Name (_HID, "INT3474") - Name (_UID, 0) /* _UID: Unique ID */ + Name (_UID, 0) Name (_DDN, "Ov 2740 Camera") /* _DDN: DOS Device Name */ Method (_STA, 0, NotSerialized) /* _STA: Status */ { diff --git a/src/mainboard/google/volteer/variants/voema/include/variant/acpi/mipi_camera.asl b/src/mainboard/google/volteer/variants/voema/include/variant/acpi/mipi_camera.asl index 290d2b6..e98cd60 100644 --- a/src/mainboard/google/volteer/variants/voema/include/variant/acpi/mipi_camera.asl +++ b/src/mainboard/google/volteer/variants/voema/include/variant/acpi/mipi_camera.asl @@ -158,7 +158,7 @@ Device (CAM1) { Name (_HID, "INT3474") - Name (_UID, 0) /* _UID: Unique ID */ + Name (_UID, 0) Name (_DDN, "Ov 2740 Camera") /* _DDN: DOS Device Name */ Method (_STA, 0, NotSerialized) /* _STA: Status */ { @@ -274,7 +274,7 @@ Device (NVM0) { Name (_HID, "PRP0001") - Name (_UID, 0x01) // _UID: Unique ID + Name (_UID, 0x01) Name (_DDN, "AT24 EEPROM") // _DDN: DOS Device Name Method (_STA, 0, NotSerialized) // _STA: Status { diff --git a/src/mainboard/intel/kblrvp/acpi/mipi_camera.asl b/src/mainboard/intel/kblrvp/acpi/mipi_camera.asl index 292e548..481d96d 100644 --- a/src/mainboard/intel/kblrvp/acpi/mipi_camera.asl +++ b/src/mainboard/intel/kblrvp/acpi/mipi_camera.asl @@ -5,7 +5,7 @@ Device (PMIC) { Name (_HID, "INT3472") - Name (_UID, 0) // _UID: Unique ID */ + Name (_UID, 0) */ Name (_DDN, "TPS68470 PMIC") /* _DDN: DOS Device Name */ Name (CAMD, 0x64)
@@ -370,7 +370,7 @@ Device (CAM0) { Name (_HID, "OVTID858") - Name (_UID, 0) /* _UID: Unique ID */ + Name (_UID, 0) Name (_DDN, "OV 13858 Camera") /* _DDN: DOS Device Name */ Name (CAMD, 0x02)
@@ -475,7 +475,7 @@ Device (VCM0) { Name (_HID, "DWDWD000") - Name (_UID, 0) /* _UID: Unique ID */ + Name (_UID, 0) Name (_DDN, "Dongwoon AF DAC") /* _DDN: DOS Device Name */ Name (CAMD, 0x03)
@@ -503,7 +503,7 @@ Device (PMIC) { Name (_HID, "INT3473") - Name (_UID, 0) /* _UID: Unique ID */ + Name (_UID, 0) Name (_DDN, "TPS68470 PMIC 2") /* _DDN: DOS Device Name */ Name (CAMD, 0x64)
@@ -806,7 +806,7 @@ Device (CAM1) { Name (_HID, "INT3479") - Name (_UID, 0) /* _UID: Unique ID */ + Name (_UID, 0) Name (_DDN, "OV 5670 Camera") /* _DDN: DOS Device Name */ Name (CAMD, 0x02)
diff --git a/src/mainboard/intel/tglrvp/acpi/mipi_camera.asl b/src/mainboard/intel/tglrvp/acpi/mipi_camera.asl index 8159fa7..d4f2031 100644 --- a/src/mainboard/intel/tglrvp/acpi/mipi_camera.asl +++ b/src/mainboard/intel/tglrvp/acpi/mipi_camera.asl @@ -199,7 +199,7 @@ Device (CAM0) { Name (_HID, "OVTI8856") - Name (_UID, 0) /* _UID: Unique ID */ + Name (_UID, 0) Name (_DDN, "Ov 8856 Camera") /* _DDN: DOS Device Name */ Method (_STA, 0, NotSerialized) /* _STA: Status */ { @@ -322,7 +322,7 @@ Device (VCM0) { Name (_HID, "PRP0001") - Name (_UID, 0x03) /* _UID: Unique ID */ + Name (_UID, 0x03) Name (_DDN, "DW9714 VCM") /* _DDN: DOS Device Name */ Method (_STA, 0, NotSerialized) /* _STA: Status */ { @@ -422,7 +422,7 @@ Device (CAM1) { Name (_HID, "OVTI8856") - Name (_UID, 0) /* _UID: Unique ID */ + Name (_UID, 0) Name (_DDN, "Ov 8856 Camera") /* _DDN: DOS Device Name */ Method (_STA, 0, NotSerialized) /* _STA: Status */ { diff --git a/src/mainboard/starlabs/lite/acpi/touchpad.asl b/src/mainboard/starlabs/lite/acpi/touchpad.asl index 2f9c27c..44eb8d8 100644 --- a/src/mainboard/starlabs/lite/acpi/touchpad.asl +++ b/src/mainboard/starlabs/lite/acpi/touchpad.asl @@ -6,7 +6,7 @@ { Name (_HID, "STAR0001") Name (_CID, "PNP0C50" /* HID Protocol Device (I2C bus) */) - Name (_UID, 0x01) // _UID: Unique ID + Name (_UID, 0x01) Name (_DDN, "Touchpad") // _DDN: DOS Device Name Name (_DEP, Package (0x02) // _DEP: Dependencies { diff --git a/src/mainboard/system76/kbl-u/acpi/battery.asl b/src/mainboard/system76/kbl-u/acpi/battery.asl index a3287e3..6fd0bed 100644 --- a/src/mainboard/system76/kbl-u/acpi/battery.asl +++ b/src/mainboard/system76/kbl-u/acpi/battery.asl @@ -3,7 +3,7 @@ Device (BAT0) { Name (_HID, EisaId ("PNP0C0A") /* Control Method Battery */) - Name (_UID, 0) // _UID: Unique ID + Name (_UID, 0) Name (_PCL, Package (0x01) // _PCL: Power Consumer List { _SB diff --git a/src/soc/intel/common/block/acpi/acpi/northbridge.asl b/src/soc/intel/common/block/acpi/acpi/northbridge.asl index 65c7588..d605625 100644 --- a/src/soc/intel/common/block/acpi/acpi/northbridge.asl +++ b/src/soc/intel/common/block/acpi/acpi/northbridge.asl @@ -6,7 +6,7 @@ Name (_HID, EisaId ("PNP0A08") /* PCI Express Bus */) Name (_CID, EisaId ("PNP0A03") /* PCI Bus */) Name (_SEG, 0) // _SEG: PCI Segment -Name (_UID, 0) // _UID: Unique ID +Name (_UID, 0)
Device (MCHC) { diff --git a/src/soc/intel/skylake/acpi/systemagent.asl b/src/soc/intel/skylake/acpi/systemagent.asl index 0fdaab9..0e5d74f 100644 --- a/src/soc/intel/skylake/acpi/systemagent.asl +++ b/src/soc/intel/skylake/acpi/systemagent.asl @@ -6,7 +6,7 @@ Name (_HID, EisaId ("PNP0A08") /* PCI Express Bus */) Name (_CID, EisaId ("PNP0A03") /* PCI Bus */) Name (_SEG, 0) // _SEG: PCI Segment -Name (_UID, 0) // _UID: Unique ID +Name (_UID, 0)
Device (MCHC) {