Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50150 )
Change subject: soc/amd/stoneyridge/psp: fix check of MSR_PSP_ADDR contents
......................................................................
Patch Set 2:
(1 comment)
File src/soc/amd/stoneyridge/psp.c:
https://review.coreboot.org/c/coreboot/+/50150/comment/7fcf567c_fc0f66a3
PS1, Line 48: if (!psp_mmio) {
the Stoneyridge datasheet says that it's all zeros if uninitialized. […]
Yeah, this is why I added this comment as resolved.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50150
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I06399ac9cb9c90701dbcba71cbc808a0d7e6ea0d
Gerrit-Change-Number: 50150
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-Comment-Date: Sun, 31 Jan 2021 09:49:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment