Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43595 )
Change subject: post_code: replace postcode constants in mainboard EC init
......................................................................
Patch Set 1: Code-Review+2
Patch Set 1: Code-Review+2
The post codes should be moved to the calling code in a follow up, to remove those duplicates.
The calling code isn't common, though (this function is declared in src/ec/ec.h, but only mainboards define and call it)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43595
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I79768edf42087901a1925f47b7772d5347b41b3f
Gerrit-Change-Number: 43595
Gerrit-PatchSet: 1
Gerrit-Owner: Sindhoor Tilak
sindhoor@sin9yt.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 31 Jul 2020 08:44:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment