Attention is currently required from: Frank Wu, Tim Wawrzynczak, Eric Lai.
Amanda Hwang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62998 )
Change subject: mb/google/brya/var/brya0: Replace amp max98357 with max98360
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS1:
Will this broken the OEM string, looks like a little long? try dmidecode to see the OEM string
I have verified with local build kernel to test OEM string, and works fine.
Handle 0x0009, DMI type 11, 5 bytes
OEM Strings
String 1: AUDIO-MAX98360_ALC5682I_I2S_AMP_SSP2
String 2: DB_LTE-LTE_PCIE
String 3: UFC-UFC_MIPI_IMX208
File src/mainboard/google/brya/variants/brya0/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/62998/comment/45fdeed9_c138a7e8
PS1, Line 15: option AUDIO_UNKNOWN 0
: option MAX98357_ALC5682I_I2S 1
: option MAX98373_ALC5682_SNDW 2
: option MAX98373_NAU88L25B_I2S 3
: option ALC1019_NAU88L25B_I2S 4
: option MAX98360_ALC5682I_I2S_AMP_SSP2 5
can you please align the right-hand side of all of these to match?
Done.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62998
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3033e31cf5c2dade02dc19531f5e5365eeeb7a78
Gerrit-Change-Number: 62998
Gerrit-PatchSet: 2
Gerrit-Owner: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Attention: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Wed, 23 Mar 2022 02:35:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment