Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Martin L Roth, Martin Roth, Matt DeVillier, Varshit Pandya.
Nick Kochlowski has posted comments on this change by Nick Kochlowski. ( https://review.coreboot.org/c/coreboot/+/85632?usp=email )
Change subject: drivers/amd/opensil/mpio: Factor out common MPIO symbols from vendorcode ......................................................................
Patch Set 7:
(6 comments)
File src/drivers/amd/opensil/mpio/chip.h:
https://review.coreboot.org/c/coreboot/+/85632/comment/89e9bda9_0496001f?usp... : PS6, Line 8: void configure_mpio(void);
putting this into the driver's opensil. […]
Done
File src/drivers/amd/opensil/mpio/chip.c:
https://review.coreboot.org/c/coreboot/+/85632/comment/9a28d49d_d9e26875?usp... : PS6, Line 8: struct chip_operations drivers_amd_opensil_mpio_ops = { : .name = "AMD MPIO", : };
i'd say that the chip.c is the right place for this specific one. […]
Understood. Seeing as the devicetree/chip ops usage is not conventional as Felix had explained, this could maybe stay here for the time being?
File src/vendorcode/amd/opensil/Kconfig:
https://review.coreboot.org/c/coreboot/+/85632/comment/5e879569_0d5276cc?usp... : PS6, Line 28: ../../../../vendorcode
if this works, that would be preferrable. […]
Done
File src/vendorcode/amd/opensil/genoa_poc/mpio/chip.c:
https://review.coreboot.org/c/coreboot/+/85632/comment/b4f02ab0_65be8a86?usp... : PS6, Line 134: //
/* */ comment style
Done
https://review.coreboot.org/c/coreboot/+/85632/comment/1719be40_2cd22b8f?usp... : PS6, Line 202: }
i think this is missing the final newline
Done
File src/vendorcode/amd/opensil/stub/mpio/chip.c:
https://review.coreboot.org/c/coreboot/+/85632/comment/4cac703f_eec056d3?usp... : PS6, Line 6: "../../opensil.h"
<src/vendorcode/amd/opensil/opensil. […]
Done