Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31787 )
Change subject: soc/intel/cannonlake: Move power_state functions to pmutil.c ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31787/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31787/2//COMMIT_MSG@10 PS2, Line 10: It allows the functions to be used across romstage and smm. : Can this not be achieved by just adding power_state.c to smm stage?