Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32003 )
Change subject: mb/google/hatch: Add overridetree to hatch variant ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/#/c/32003/1/src/mainboard/google/hatch/Kconfig File src/mainboard/google/hatch/Kconfig:
https://review.coreboot.org/#/c/32003/1/src/mainboard/google/hatch/Kconfig@4... PS1, Line 43: BOARD_GOOGLE_HATCH_WHL Now that we are adding override tree, we should move devices like touchscreen, trackpad, etc. to override tree. Okay to do in follow-up change
https://review.coreboot.org/#/c/32003/1/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/hatch/overridetree.cb:
https://review.coreboot.org/#/c/32003/1/src/mainboard/google/hatch/variants/... PS1, Line 8: PchSerialIoDisabled Why? We are using this: https://review.coreboot.org/cgit/coreboot.git/tree/src/mainboard/google/hatc...
https://review.coreboot.org/#/c/32003/1/src/mainboard/google/hatch/variants/... PS1, Line 13: PchSerialIoSkipInit PchSerialIoPci should probably be okay here?
https://review.coreboot.org/#/c/32003/1/src/mainboard/google/hatch/variants/... PS1, Line 15: PchSerialIoSkipInit Why? Shouldn't this be PchSerialIoDisabled?