[coreboot-gerrit] Change in coreboot[master]: intel/common/../systemagent: Add sa_get_mchbar_base api

[Tim Wawrzynczak (Code Review)]

Attention is currently required from: Subrata Banik, Wonkyu Kim, Paul Menzel, Angel Pons, Michael Niewöhner.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63615 )

Change subject: intel/common/../systemagent: Add sa_get_mchbar_base api
......................................................................

Patch Set 12:

(4 comments)

Patchset:

PS12:
> I commented yesterday: […]

I agree, I think this belongs in some chipset specific code, not in common code, if MTL has different requirements than others

File src/soc/intel/common/block/systemagent/systemagent_early.c:

https://review.coreboot.org/c/coreboot/+/63615/comment/5dfd2530_fa8b8d66 
PS12, Line 87: 4
nit:
`sizeof(uint32_t)`

https://review.coreboot.org/c/coreboot/+/63615/comment/9ddec93e_2af6380f 
PS12, Line 89: 0x1
used here and line 97, how about a
`#define MCHBAREN    0x1`
?

https://review.coreboot.org/c/coreboot/+/63615/comment/d80a4beb_060d5f5c 
PS12, Line 95: 4
nit:
`sizeof(uint32_t)`