Attention is currently required from: Shiyu Sun, Edward Hill.
Sam McNally has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48229 )
Change subject: mb/google/zork: add MST details to trembyle devicetree
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb:
https://review.coreboot.org/c/coreboot/+/48229/comment/62013126_7416b58a
PS2, Line 380: 1b
Sorry may I know where this number come from?
It's the 7-bit i2c address.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48229
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I97a67f9dbc31cd788d579252d7d355b24d97ca30
Gerrit-Change-Number: 48229
Gerrit-PatchSet: 2
Gerrit-Owner: Shiyu Sun
sshiyu@google.com
Gerrit-Reviewer: Edward Hill
ecgh@chromium.org
Gerrit-Reviewer: Sam McNally
sammc@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Matthew Blecker
matthewb@chromium.org
Gerrit-Attention: Shiyu Sun
sshiyu@google.com
Gerrit-Attention: Edward Hill
ecgh@chromium.org
Gerrit-Comment-Date: Mon, 25 Jan 2021 03:43:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sam McNally
sammc@google.com
Comment-In-Reply-To: Shiyu Sun
sshiyu@google.com
Gerrit-MessageType: comment