Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43844 )
Change subject: soc/skylake: Enable LAN depending on devicetree configuration
......................................................................
Patch Set 6:
(3 comments)
https://review.coreboot.org/c/coreboot/+/43844/5//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/43844/5//COMMIT_MSG@9
PS5, Line 9: EnableLAN
EnableLan
Done
https://review.coreboot.org/c/coreboot/+/43844/5//COMMIT_MSG@14
PS5, Line 14: EnableLAN
EnableLan
Done
https://review.coreboot.org/c/coreboot/+/43844/5/src/soc/intel/skylake/chip....
File src/soc/intel/skylake/chip.c:
https://review.coreboot.org/c/coreboot/+/43844/5/src/soc/intel/skylake/chip....
PS5, Line 246: dev ? dev->enabled : 0
`dev && dev->enabled`
I would leave it like that to keep the consistency, since the existing code is handled like that.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43844
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I36347e8e0f0ddba47aec52aeb6bc047e3c8bfaa4
Gerrit-Change-Number: 43844
Gerrit-PatchSet: 6
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 25 Jul 2020 09:42:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment