[coreboot-gerrit] Change in coreboot[master]: security/vboot: Add vboot callbacks to support EC software sync

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36208 )

Change subject: security/vboot: Add vboot callbacks to support EC software sync
......................................................................

Patch Set 16:

(3 comments)

https://review.coreboot.org/c/coreboot/+/36208/16/src/security/vboot/ec_sync... 
File src/security/vboot/ec_sync.c:

https://review.coreboot.org/c/coreboot/+/36208/16/src/security/vboot/ec_sync... 
PS16, Line 264: 			     sizeof(struct ec_host_request));
nit: might be nice to align with 'resp...'?

https://review.coreboot.org/c/coreboot/+/36208/16/src/security/vboot/ec_sync... 
PS16, Line 285: 		uint32_t block_size = todo + sizeof(*params);
nit: block_size sounds quite weird because that makes me think of the flash block. maybe xfer_size?

https://review.coreboot.org/c/coreboot/+/36208/16/src/security/vboot/ec_sync... 
PS16, Line 432: 	int in_recovery = !!sd->recovery_reason;
Here too please check the context flag instead.