Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43495 )
Change subject: soc/amd/picasso: Configure ACP_PME_EN and ACP_I2S_WAKE_EN
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/43495/4/src/soc/amd/picasso/acp.c
File src/soc/amd/picasso/acp.c:
https://review.coreboot.org/c/coreboot/+/43495/4/src/soc/amd/picasso/acp.c@3...
PS4, Line 38: write32((void *)(bar + ACP_PME_EN), !!cfg->acpi_pme_enable);
We should technically be doing a r-m-w since the other bits are marked 'reserved'.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43495
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I522d7497940f499fbc3181d866f2b44e979bba7a
Gerrit-Change-Number: 43495
Gerrit-PatchSet: 4
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Akshu Agrawal
akshu.agrawal@amd.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 16 Jul 2020 05:16:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment