Attention is currently required from: Arthur Heymans.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46908 )
Change subject: cpu/intel/haswell: Factor out ACPI C-state values
......................................................................
Patch Set 14:
(1 comment)
File src/cpu/intel/haswell/acpi.c:
https://review.coreboot.org/c/coreboot/+/46908/comment/fd3087ba_753583e8
PS14, Line 16:
: static int cstate_set_lp[3] = {
: 2,
: 3,
: 9,
: };
:
: static int cstate_set_trad[3] = {
: 1,
: 3,
: 5,
: };
If those match with the enum values in haswell_init.c it would be nice to reuse those.
Done in the next change: CB:46923
This patch simply factors out the numbers. I didn't want to replace them with enum values in the same commit, as it would be harder to follow what is going on.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46908
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3a788423aee9be279797a1f7c60ab892a0af37e7
Gerrit-Change-Number: 46908
Gerrit-PatchSet: 14
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Tue, 12 Jan 2021 17:04:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment