Attention is currently required from: Stefan Ott, Alexander Couzens, Patrick Rudolph.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55315 )
Change subject: drivers/generic/ioapic: Use register_new_ioapic_gsi0()
......................................................................
Patch Set 9: Code-Review-2
(1 comment)
File src/mainboard/lenovo/t400/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/55315/comment/cf3eb6e2_31a75f5e
PS9, Line 136: ioapic_irq 2 INTA 0x10
We are linking to this with the ioapic id I suggest to remove. Potentially only used with MP table but I will check.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55315
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4b03d32fa16fb9eb8a035e58bb7e3e027904f076
Gerrit-Change-Number: 55315
Gerrit-PatchSet: 9
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Stefan Ott
coreboot@desire.ch
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Stefan Ott
coreboot@desire.ch
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 10 Nov 2022 19:17:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment