Attention is currently required from: Ravi kumar, Shelley Chen, Julius Werner. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49768 )
Change subject: sc7280: cpucp loading changes ......................................................................
Patch Set 40:
(42 comments)
File src/soc/qualcomm/sc7280/cpucp_load_reset.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119803): https://review.coreboot.org/c/coreboot/+/49768/comment/88581474_8b249c54 PS40, Line 15: uint32_t val = read32(EPSSTOP_SECURE_ACCESS_OVERRIDE); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119803): https://review.coreboot.org/c/coreboot/+/49768/comment/a4dacf8d_31ee5395 PS40, Line 15: uint32_t val = read32(EPSSTOP_SECURE_ACCESS_OVERRIDE); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119803): https://review.coreboot.org/c/coreboot/+/49768/comment/5e70be29_d4b1ae2f PS40, Line 16: val |= 0x1; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119803): https://review.coreboot.org/c/coreboot/+/49768/comment/44881970_46e10e29 PS40, Line 16: val |= 0x1; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119803): https://review.coreboot.org/c/coreboot/+/49768/comment/492c4276_210d0942 PS40, Line 18: /* allow NS access to EPSS memory*/ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119803): https://review.coreboot.org/c/coreboot/+/49768/comment/c9132c3b_5479c419 PS40, Line 19: write32(EPSSTOP_SECURE_ACCESS_OVERRIDE, val); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119803): https://review.coreboot.org/c/coreboot/+/49768/comment/d2f30a7e_e1c55765 PS40, Line 19: write32(EPSSTOP_SECURE_ACCESS_OVERRIDE, val); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119803): https://review.coreboot.org/c/coreboot/+/49768/comment/4036f94c_6bf4310f PS40, Line 21: val = read32(EPSSFAST_EPSS_MUC_CLK_CTRL); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119803): https://review.coreboot.org/c/coreboot/+/49768/comment/639ce8cb_d985fc21 PS40, Line 21: val = read32(EPSSFAST_EPSS_MUC_CLK_CTRL); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119803): https://review.coreboot.org/c/coreboot/+/49768/comment/449af521_87534ce9 PS40, Line 22: val |= 0x1; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119803): https://review.coreboot.org/c/coreboot/+/49768/comment/f9176940_4183d47f PS40, Line 22: val |= 0x1; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119803): https://review.coreboot.org/c/coreboot/+/49768/comment/d6b21c02_3bbe6263 PS40, Line 24: /* Enable subsystem clock. Required for CPUCP PDMEM access*/ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119803): https://review.coreboot.org/c/coreboot/+/49768/comment/88960bc7_ed795f21 PS40, Line 25: write32(EPSSFAST_EPSS_MUC_CLK_CTRL, val); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119803): https://review.coreboot.org/c/coreboot/+/49768/comment/850fc005_d3412a09 PS40, Line 25: write32(EPSSFAST_EPSS_MUC_CLK_CTRL, val); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119803): https://review.coreboot.org/c/coreboot/+/49768/comment/3f23fe0a_db7aad13 PS40, Line 27: while((read32(EPSSFAST_EPSS_MUC_CLK_CTRL) & 0x1) != 0x1); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119803): https://review.coreboot.org/c/coreboot/+/49768/comment/8fdebf68_68261dfd PS40, Line 27: while((read32(EPSSFAST_EPSS_MUC_CLK_CTRL) & 0x1) != 0x1); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119803): https://review.coreboot.org/c/coreboot/+/49768/comment/e31e78af_36b6e636 PS40, Line 27: while((read32(EPSSFAST_EPSS_MUC_CLK_CTRL) & 0x1) != 0x1); space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119803): https://review.coreboot.org/c/coreboot/+/49768/comment/6ff7a4f1_178de2cc PS40, Line 27: while((read32(EPSSFAST_EPSS_MUC_CLK_CTRL) & 0x1) != 0x1); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119803): https://review.coreboot.org/c/coreboot/+/49768/comment/7cb5df02_9cc237ce PS40, Line 32: bool cpucp_fw_entry; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119803): https://review.coreboot.org/c/coreboot/+/49768/comment/8736534c_9b2a07c3 PS40, Line 32: bool cpucp_fw_entry; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119803): https://review.coreboot.org/c/coreboot/+/49768/comment/99348b8a_82f79419 PS40, Line 33: printk(BIOS_DEBUG, "\nSOC:CPUCP image loading.\n"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119803): https://review.coreboot.org/c/coreboot/+/49768/comment/d1f1541d_bcb303d7 PS40, Line 33: printk(BIOS_DEBUG, "\nSOC:CPUCP image loading.\n"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119803): https://review.coreboot.org/c/coreboot/+/49768/comment/862a5b38_39d2893f PS40, Line 35: struct prog cpucp_fw_prog = code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119803): https://review.coreboot.org/c/coreboot/+/49768/comment/f82c4c6d_25e16d34 PS40, Line 35: struct prog cpucp_fw_prog = please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119803): https://review.coreboot.org/c/coreboot/+/49768/comment/88d240fb_7bb80bc0 PS40, Line 36: PROG_INIT(PROG_PAYLOAD, CONFIG_CBFS_PREFIX "/cpucp"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119803): https://review.coreboot.org/c/coreboot/+/49768/comment/abb22427_8f10a630 PS40, Line 36: PROG_INIT(PROG_PAYLOAD, CONFIG_CBFS_PREFIX "/cpucp"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119803): https://review.coreboot.org/c/coreboot/+/49768/comment/9c3a328f_e3b25681 PS40, Line 38: cpucp_prepare(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119803): https://review.coreboot.org/c/coreboot/+/49768/comment/d5dd31e9_0bb2a469 PS40, Line 38: cpucp_prepare(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119803): https://review.coreboot.org/c/coreboot/+/49768/comment/64d5baa2_702fc435 PS40, Line 40: if (prog_locate(&cpucp_fw_prog)) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119803): https://review.coreboot.org/c/coreboot/+/49768/comment/ee8ab9ae_1a7ff0fd PS40, Line 40: if (prog_locate(&cpucp_fw_prog)) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119803): https://review.coreboot.org/c/coreboot/+/49768/comment/7f28383a_b62fd451 PS40, Line 41: die("SOC imagpe: CPUCP_FW not found"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119803): https://review.coreboot.org/c/coreboot/+/49768/comment/cd551d53_0c6efe69 PS40, Line 41: die("SOC imagpe: CPUCP_FW not found"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119803): https://review.coreboot.org/c/coreboot/+/49768/comment/7c25b903_3f62e5a1 PS40, Line 43: cpucp_fw_entry = selfload(&cpucp_fw_prog); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119803): https://review.coreboot.org/c/coreboot/+/49768/comment/19154784_96f3e664 PS40, Line 43: cpucp_fw_entry = selfload(&cpucp_fw_prog); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119803): https://review.coreboot.org/c/coreboot/+/49768/comment/db21f878_ce27020e PS40, Line 44: if (!cpucp_fw_entry) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119803): https://review.coreboot.org/c/coreboot/+/49768/comment/b16709f4_875f3851 PS40, Line 44: if (!cpucp_fw_entry) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119803): https://review.coreboot.org/c/coreboot/+/49768/comment/4dff14f4_25fe85d3 PS40, Line 45: die("SOC image: CPUCP load failed"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119803): https://review.coreboot.org/c/coreboot/+/49768/comment/1ce1d222_d883d4eb PS40, Line 45: die("SOC image: CPUCP load failed"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119803): https://review.coreboot.org/c/coreboot/+/49768/comment/27b314a2_b0fb5a58 PS40, Line 47: printk(BIOS_DEBUG, "\nSOC:CPUCP image loaded successfully.\n"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119803): https://review.coreboot.org/c/coreboot/+/49768/comment/c3f329a4_f524d1ec PS40, Line 47: printk(BIOS_DEBUG, "\nSOC:CPUCP image loaded successfully.\n"); please, no spaces at the start of a line
File src/soc/qualcomm/sc7280/soc.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119803): https://review.coreboot.org/c/coreboot/+/49768/comment/36d43b45_3a74d3d9 PS40, Line 20: REGION_SIZE(dram_cpucp) / KiB); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119803): https://review.coreboot.org/c/coreboot/+/49768/comment/d48bdc78_f094681f PS40, Line 20: REGION_SIZE(dram_cpucp) / KiB); please, no spaces at the start of a line